Skip to content

Fixing Missing End Effector Link for UR-X URDF models - #167

Closed
suddrey-qut wants to merge 1 commit into
petercorke:mainfrom
suddrey-qut:master
Closed

Fixing Missing End Effector Link for UR-X URDF models#167
suddrey-qut wants to merge 1 commit into
petercorke:mainfrom
suddrey-qut:master

Conversation

@suddrey-qut

Copy link
Copy Markdown
Contributor

Many of the manipulator robot models do not have clearly defined end-effector links. This causes a crash when calling robot.fkine(robot.q).

I have updated the UR-X models to resolve this by specifying explicitly the gripper links, and have added a unit test to cover this issue.

Please note that the unit test is still failing due to the other models not having end effector links specified, but I am not sufficiently versed in these models to determine how to fix them.

@petercorke

Copy link
Copy Markdown
Owner

Grippers and end effectors are still WIP, some thoughts on the Wiki https://github.com/petercorke/robotics-toolbox-python/wiki/Grippers

@petercorke

Copy link
Copy Markdown
Owner

Thank you for your interest in RTB, and for catching this — missing end-effector links causing a crash on fkine() was a real problem.

This PR (#167) predates a large amount of restructuring since 2021: the base class you're working against here (ERobot, with urdf_to_ets_args()) no longer exists — ERobot is now Robot/URDFRobot, loaded via URDFRobot.__init__(name, ..., gripper_link_index=N) directly, so this specific diff can't apply as written.

The underlying concern is partially addressed today: UR5 already passes gripper_link_index=7. UR3/UR10 still don't — worth a fresh look with today's model classes if you're up for it, but closing this one given how much has moved underneath it. Thanks again for the original catch.

@petercorke petercorke closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants